ci(chore) - various updates to replace deprecated action notices and red builds#270
Merged
rholshausen merged 5 commits intopact-foundation:masterfrom May 1, 2023
Merged
Conversation
Contributor
|
Nice one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @uglyog
Noted the CI workflows were throwing a few deprecation notices, and the release workflow was failing on any jobs that were for the ffi, verifier cli, or mock server cli, so this PR add's a few changes to clean up the build
actions/checkout@v2toactions/checkout@v3actions-rs/toolchain@v1withdtolnay/rust-toolchainhttps://github.com/dtolnay/rust-toolchain as original unmaintained - see issuemarcopolo/cargo@masteralso unmaintained, and not sure using an action for this adds value based on what we are using from it, with a cargo rust/test/build and setting theworking-directoryas part of the gh action step valuechoco install -y llvmfrom windows build-chain, llvm is already installed on windows runners https://github.com/actions/runner-images/blob/d8d4d924ad21a8ba4931b2988f74bbb376cad021/images/win/toolsets/toolset-2022.json#L400nightly-2022-12-01withnightly- fails with updated toolchain actions update, it looks like the underlying reason for it being pinned has been fixed Cbindgen fails on latest nightly (1.68.0-nightly) with an internal compiler error rust-lang/rust#105886